Open
Conversation
altsem
reviewed
Apr 23, 2026
|
|
||
| let mut opts = DiffOptions::new(); | ||
| let diff = repo | ||
| .diff_tree_to_tree(parent_tree.as_ref(), Some(¤t_tree), Some(&mut opts)) |
Owner
There was a problem hiding this comment.
I reckon this becomes quite expensive, diffing each commit to the previous. It does take a few seconds to complete a search for me in the Gitu repo with a release-build.
I've been replacing other parts of (lib)git2 uses with simply command forks. git log --oneline --grep 'test' might do the job. Perhaps there's a lower-level, more stable command than git log --grep that is more suitable for scripting (aka plumbing-command). Would require some rework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make testis passing (this is what CI runs).feat:/fix:/style:/perf:. Or e.g.perf(highlighting):.See https://github.com/altsem/gitu/blob/master/docs/dev-tooling.md