-
Notifications
You must be signed in to change notification settings - Fork 0
[fix] 대타 요청 비즈니스 로직 API 수정 #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
353c719
feat : tanstackquery devtools 라이브러리 추가
kim3360 20431ab
fix : G3 근무시간 하드코딩 부분 스케줄 시간 데이터로 변경
kim3360 6baaec9
fix : G4 보낸/받은 대타요청 필터 할성화
kim3360 c7fa4f4
fix : G6 매니저 승인 코멘트 선택적 변경
kim3360 3dd79da
fix : G4 매니저 상태 필터 활성화
kim3360 e616be5
fix : G7 enum 래퍼 처리
kim3360 c02bf3d
fix : 대타 카드 UI 변경
kim3360 1547120
fix : G8 응답 형태 방어 코드 수정
kim3360 5d95da3
fix : 대타 필터 공통 타입 shared 분리 및 FSD import 정리
kim3360 8b1244c
fix : unwrapSubstituteEnum value 비정상 응답 방어 처리
kim3360 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dohy-eon marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| export { | ||
| MANAGER_FILTER_TO_API_STATUS, | ||
| resolveManagerApiStatuses, | ||
| } from '@/features/manager/substitute/lib/managerSubstituteListFilters' | ||
| export type { ManagerSubstituteListFilters } from '@/features/manager/substitute/lib/managerSubstituteListFilters' | ||
| export { | ||
| useManagerSubstituteRequestViewModel, | ||
| type ManagerSubstituteSection, | ||
| } from '@/features/manager/substitute/hooks/useManagerSubstituteRequestViewModel' |
23 changes: 23 additions & 0 deletions
23
src/features/manager/substitute/lib/managerSubstituteListFilters.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import type { SubstituteListStatusFilter } from '@/shared/types/substituteListFilters' | ||
| import { SubstituteApiStatus } from '@/shared/types/substituteStatus' | ||
|
|
||
| export type ManagerSubstituteListFilters = { | ||
| statusFilter: SubstituteListStatusFilter | ||
| } | ||
|
|
||
| /** 매니저 UI 필터 → API status (G5 기준) */ | ||
| export const MANAGER_FILTER_TO_API_STATUS: Record< | ||
| SubstituteListStatusFilter, | ||
| SubstituteApiStatus[] | ||
| > = { | ||
| all: [], | ||
| pending: [SubstituteApiStatus.ACCEPTED], | ||
| accepted: [SubstituteApiStatus.APPROVED], | ||
| cancelled: [SubstituteApiStatus.REJECTED_BY_APPROVER], | ||
| } | ||
|
|
||
| export function resolveManagerApiStatuses( | ||
| filter: SubstituteListStatusFilter | ||
| ): SubstituteApiStatus[] { | ||
| return MANAGER_FILTER_TO_API_STATUS[filter] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
Repository: alter-app/alter-client
Length of output: 249
🏁 Script executed:
Repository: alter-app/alter-client
Length of output: 229
🏁 Script executed:
Repository: alter-app/alter-client
Length of output: 229
@tanstack/react-query와 Devtools 버전을 맞춰주세요.@tanstack/react-query-devtools@5.101.1은@tanstack/react-query@^5.101.1을 요구하므로, 현재^5.90.21과 peer 조건이 맞지 않습니다.react-query를^5.101.1로 올리거나 Devtools를 같은 릴리스 라인으로 내리세요.🤖 Prompt for AI Agents