fix bug where created_at is overwritten for pending files at version 0#4884
Open
rparke wants to merge 2 commits into
Open
fix bug where created_at is overwritten for pending files at version 0#4884rparke wants to merge 2 commits into
created_at is overwritten for pending files at version 0#4884rparke wants to merge 2 commits into
Conversation
rparke
force-pushed
the
rp-fix-versioning-archive-files
branch
from
0dae771 to
c7789ce
Compare
CrystalPea
approved these changes
Jun 17, 2026
pending files are given a version of 0 when they are created to indicate that they don't properly "belong" to a template yet. This causes an odd bug when dao methods are wrapped with the `@version_class` decorator, the files have their `created_at` attribute overwritten with the current datetime. Since we don't care about the versioning of pending files that go straight into archived anyway, we shouldn't be using version_class wrapped methods anyway for this purpose. Files that are automatically archived from pending will now just remain at version 0.
It is a waste of time looping through files that are already archived, and could throw hard to debug sqlalchemy errors
rparke
force-pushed
the
rp-fix-versioning-archive-files
branch
from
c7789ce to
01a2368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pending files are given a version of 0 when they are created to indicate that they don't properly "belong" to a template yet. This causes an odd bug when dao methods are wrapped with the
@version_classdecorator, the files have theircreated_atattribute overwritten with the current datetime. Since we don't care about the versioning of pending files that go straight into archived anyway, we shouldn't be using version_class wrapped methods anyway for this purpose.Files that are automatically archived from pending will now just remain at version 0.
Also fixes a small issue where we were needlessly looping through the list of all pending files, archived or not.