Stop users uploading attaching empty files to templates#5963
Merged
Conversation
Motivation for doing this now is it stops us detecting the mimetype of the file. However there’s probably no need for people to be sending empty files – in fact it’s most likey testing or a mistake. And since in the UI we can warn people at the time of uploading, not sending, it seems like it doesn’t hurt to add some validation.
quis
force-pushed
the
validate-empty-template-email-files
branch
from
6009e36 to
77b2844
Compare
rparke
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why do this now? Because we cannot detect the mimetype of an empty file.
However there’s probably no need for people to be sending empty files – in fact it’s most likely testing or a mistake. And since in the UI we can warn people at the time of uploading, not sending, it seems like it doesn’t hurt to add some validation.