Repository navigation
fix: keep macOS traffic lights aligned when resizing - #812
Conversation
Assisted-by: gpt-6.1-terra
[Medium impact] The changes affect the macOS desktop window’s title-bar layout. No behavioral blocker was established, but the repository’s utility-reuse requirement must be satisfied before merging. Findings
Fix with agent prompt### Issue 1
ui/src/App.tsx:1818
The new arbitrary height replaces `h-titlebar` with the same calculation in pixels. `AGENTS.md` requires using existing project utilities instead of arbitrary values. Keep `h-titlebar`; if the titlebar must use pixels, update the shared theme value so its other users stay consistent. This repository requirement must be satisfied before merging.
```suggestion
{projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex">
```
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryUpdates macOS window-button placement when the window resizes.
Reviews (1) · Last reviewed commit: "fix: keep macOS traffic lights aligned w..." · Reviewed by Greptile |
| return ( | ||
| <div className="app relative flex flex-col h-full"> | ||
| {projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-0.125rem/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex"> | ||
| {projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-[calc(44px/min(1,var(--desktop-page-zoom,1)))] items-center mac-titlebar:flex"> |
There was a problem hiding this comment.
The new arbitrary height replaces h-titlebar with the same calculation in pixels. AGENTS.md requires using existing project utilities instead of arbitrary values. Keep h-titlebar; if the titlebar must use pixels, update the shared theme value so its other users stay consistent. This repository requirement must be satisfied before merging.
| {projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-[calc(44px/min(1,var(--desktop-page-zoom,1)))] items-center mac-titlebar:flex"> | |
| {projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex"> |
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/src/App.tsx
Line: 1818
Comment:
**Titlebar height is duplicated**
The new arbitrary height replaces `h-titlebar` with the same calculation in pixels. `AGENTS.md` requires using existing project utilities instead of arbitrary values. Keep `h-titlebar`; if the titlebar must use pixels, update the shared theme value so its other users stay consistent. This repository requirement must be satisfied before merging.
```suggestion
{projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex">
```
**Context Used:** AGENTS.md ([source](https://github.com/alphaxiv/openresearch/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Before


After
Assisted-by: gpt-6.1-terra