Skip to content

fix: keep macOS traffic lights aligned when resizing - #812

Merged
myles332 merged 1 commit into
mainfrom
push-xsnyuuttqoky
Oct 28, 2026
Merged

myles332 merged 1 commit into
mainfrom
push-xsnyuuttqoky

Conversation

@paperclover

Copy link
Copy Markdown
Contributor

Before
dyn-0461ae7a41f42b23b37d73bdfd0c1173
After
image

Assisted-by: gpt-6.1-terra

@paperclover paperclover added the auto-merge Queue for automatic merge once all checks pass label Oct 28, 2026
@greptile-apps

greptile-apps Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes affect the macOS desktop window’s title-bar layout.

No behavioral blocker was established, but the repository’s utility-reuse requirement must be satisfied before merging.

Findings

  1. P2 Titlebar height is duplicated ▶
Fix with agent prompt
### Issue 1
ui/src/App.tsx:1818
The new arbitrary height replaces `h-titlebar` with the same calculation in pixels. `AGENTS.md` requires using existing project utilities instead of arbitrary values. Keep `h-titlebar`; if the titlebar must use pixels, update the shared theme value so its other users stay consistent. This repository requirement must be satisfied before merging.

```suggestion
      {projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex">
```

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Updates macOS window-button placement when the window resizes.

  • macOS traffic lights stay aligned when the app window changes size.

Reviews (1) · Last reviewed commit: "fix: keep macOS traffic lights aligned w..." · Reviewed by Greptile

Comment thread ui/src/App.tsx
return (
<div className="app relative flex flex-col h-full">
{projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-0.125rem/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex">
{projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-[calc(44px/min(1,var(--desktop-page-zoom,1)))] items-center mac-titlebar:flex">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Titlebar height is duplicated

The new arbitrary height replaces h-titlebar with the same calculation in pixels. AGENTS.md requires using existing project utilities instead of arbitrary values. Keep h-titlebar; if the titlebar must use pixels, update the shared theme value so its other users stay consistent. This repository requirement must be satisfied before merging.

Suggested change
{projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-[calc(44px/min(1,var(--desktop-page-zoom,1)))] items-center mac-titlebar:flex">
{projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex">

Context Used: AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: ui/src/App.tsx
Line: 1818

Comment:
**Titlebar height is duplicated**

The new arbitrary height replaces `h-titlebar` with the same calculation in pixels. `AGENTS.md` requires using existing project utilities instead of arbitrary values. Keep `h-titlebar`; if the titlebar must use pixels, update the shared theme value so its other users stay consistent. This repository requirement must be satisfied before merging.

```suggestion
      {projectId && <div className="absolute start-[calc(5.15rem/min(1,var(--desktop-page-zoom,1)))] top-[calc(-2px/min(1,var(--desktop-page-zoom,1)))] z-10 hidden h-titlebar items-center mac-titlebar:flex">
```

**Context Used:** AGENTS.md ([source](https://github.com/alphaxiv/openresearch/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

@myles332
myles332 merged commit 7bfa16d into main Oct 28, 2026
13 checks passed
@paperclover
paperclover deleted the push-xsnyuuttqoky branch October 28, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge Queue for automatic merge once all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants