Skip to content

Fix local Markdown file links opening duplicate chats - #765

Merged
sox8502 merged 1 commit into
mainfrom
daniel/fix-711-local-links
Oct 23, 2026
Merged

sox8502 merged 1 commit into
mainfrom
daniel/fix-711-local-links

Conversation

@sox8502

@sox8502 sox8502 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Local Markdown links written as Windows drive paths or local file:// URLs now open OpenResearch's file viewer instead of another copy of the chat. Empty, rejected, and handlerless local links render as plain text; browser URL sanitization stays enabled.

Closes #711.

Verification:

  • UI build, typecheck, and 426 UI tests, including native-path and rendered-anchor regressions.
  • macOS in-app checks: PDF/text file URLs, document preview links, and inert rejected/empty destinations.
  • Rust formatting, clippy, locked build, and locked tests (1,249 unit and 19 integration tests passed; 3 unit tests ignored).
  • Windows Server and Ubuntu backend checks with hash-verified candidate UI: PDF/text file URIs, Windows drive paths, Markdown document links, and inert rejected/empty destinations; screenshots captured through Codex’s macOS in-app browser.
  • Greptile review of 9769a9f, with 5/5 confidence and no actionable findings.
  • Original reporter's Windows 11 / Antigravity-generated transcript (original link unavailable).

The change covers shared Markdown links. Artifact-renderer local-link support, embedded file:// images, and network shares remain separate.

@sox8502

sox8502 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Routes Windows drive paths and local file:// Markdown links to the existing file viewer instead of opening another chat.

  • Local Markdown file links open in the file viewer instead of another chat.

Tests and browser checks were not rerun during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Markdown link] --> B[Save local destination separately]
  B --> C[Sanitize browser URL]
  C --> D{Recognized local file?}
  D -->|Yes| E{Valid path and file handler?}
  E -->|Yes| F[Open file viewer]
  E -->|No| G[Render plain text]
  D -->|No| H{Browser URL remains?}
  H -->|Yes| I[Render browser link]
  H -->|No| G
Loading

Reviews (2) · Last reviewed commit: "Fix local Markdown file links opening du..." · Reviewed by Greptile

@sox8502
sox8502 marked this pull request as ready for review October 23, 2026 02:51
@sox8502
sox8502 merged commit d8365f7 into main Oct 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking finished PDF opens app at http://127.0.0.1:4792/ instead of the PDF

1 participant