Skip to content

Fix sidebar menu stacking with row positioning - #762

Merged
sox8502 merged 2 commits into
mainfrom
daniel/issue-659-dev-repro
Oct 23, 2026
Merged

sox8502 merged 2 commits into
mainfrom
daniel/issue-659-dev-repro

Conversation

@sox8502

@sox8502 sox8502 commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #659.

Expanded and flat-list sidebars position virtualized rows with transforms, creating stacking contexts that let later chats cover the action menu and intercept Rename clicks. Position the same rows with top instead, preserving the existing virtualizer and menu.

The source change is one line; the remaining changes regenerate ui/dist. Latest main is integrated, including the side-chat focus fix; generated bundle conflicts were resolved by rebuilding from the merged source.

Validation

  • Reproduced the overlapping menu and intercepted Rename click on main in an isolated dev slot.
  • Verified the merged candidate in the Codex in-app browser: Rename focuses the intended chat title; Escape cancels; virtualized scrolling still works.
  • UI production build, localization lint, typecheck, style lint and 415 UI tests.
  • Rust formatting, Clippy and locked build.
  • Rust unit tests: 1,227 passed; 3 ignored.
  • Remaining Rust integration tests passed on the merged candidate.
  • Greptile review of e644f99b: 5/5, no actionable findings.
  • GitHub platform CI completes successfully.
  • Windows/Linux UI verification and bottom-edge menu clipping.

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Replaces transform with top for virtualized sidebar rows so later chats no longer cover the action menu.

  • Chat sidebar rows keep their place without covering their menus.

Reviews (2) · Last reviewed commit: "Merge origin/main and regenerate UI bund..." · Reviewed by Greptile

@sox8502

sox8502 commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@greptileai review

@sox8502
sox8502 merged commit df4d098 into main Oct 23, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Three dot problem

1 participant