Repository navigation
fix(ssh): explain rejected remote installation permissions - #628
Open
Steaming-Fresh wants to merge 1 commit into
Open
Steaming-Fresh wants to merge 1 commit into
Steaming-Fresh wants to merge 1 commit into
Conversation
Contributor
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #627
Summary
orxpath isrejected for group/other write access, instead of treating that rejection as
a missing installation or reporting that the installer produced no working
binary. This covers the default/configured-path fallback and the post-install
check.
Rejected executables are not run, the primary group is not exempted, and no
permissions are changed automatically. Initial PATH lookup and its fallback
order are unchanged.
real POSIX-shell regression tests for safe/writable files and directories,
symlinks, quoted paths, missing files, and non-executable files.
Related: #357 discusses the same directory-permission symptom. This PR is
deliberately narrower: it does not adopt primary-group exceptions or change
remote path handling.
Test plan
(directory
775, executable755); the diagnostic assertion failed beforethe fix.
cargo +1.91.1 test --locked commands::up_remote::tests: 27 passed.cargo +1.91.1 test --locked: 1,109 passed across unit/integration suites,3 existing ignored tests, 0 failures.
cargo +1.91.1 fmt --all --checkand launcher formatting check.git diff --check; ownership/permission acceptance predicates comparedunchanged against the base revision.
cargo +1.91.1 clippy --all-targets --locked -- -D warnings -A clippy::collapsible_else_if -A clippy::unnecessary_cast -A clippy::question_mark.Strict Clippy with
-D warningsreports the same four errors on both this branchand unmodified base
603558cb:collapsible_else_ifinsrc/local/chat/mod.rs,two
unnecessary_castdiagnostics insrc/local/datadir.rs, andquestion_markin
src/local/harness/opencode_v2.rs. Those unrelated files and the lintconfiguration are not changed. Native Windows execution was not tested locally;
the parser test is platform-independent and the filesystem test is Unix-only.
All reproduction data is synthetic. No workstation logs, host configuration,
credentials, screenshots, or private paths are included.