Skip to content

Fix small issues found in recent deployment#29

Open
swansontec wants to merge 1 commit into
mainfrom
william/fixes
Open

Fix small issues found in recent deployment#29
swansontec wants to merge 1 commit into
mainfrom
william/fixes

Conversation

@swansontec

Copy link
Copy Markdown
Collaborator

Description

I used this repo to initialize a new project, and ran into some issues.

  • The recent precommit PR had a typo.
  • There are several URLs that need to be changed, but no instructions to do so.
  • One URL points to a completely irrelevant repo.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

I used this repo to initialize a new project, and ran into some issues.

- The recent precommit PR had a typo.
- There are several URLs that need to be changed, but no instructions to do so.
- One URL points to a completely irrelevant repo.

@storopoli storopoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small nit.

attributes:
label: Code of Conduct
description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/alpenlabs/bitcoind-async-client/blob/main/CONTRIBUTING.md#code-of-conduct)
description: By submitting this issue, you agree to follow our [Code of Conduct](https://github.com/alpenlabs/rust-template/blob/main/CONTRIBUTING.md#code-of-conduct)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a # CHANGEME comment here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants