Skip to content

feat: Add precommit hooks#28

Merged
storopoli merged 1 commit into
mainfrom
william/pre-commit
Jun 13, 2026
Merged

feat: Add precommit hooks#28
storopoli merged 1 commit into
mainfrom
william/pre-commit

Conversation

@swansontec

@swansontec swansontec commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Description

These can be be enabled by running git config core.hooksPath .githooks. We don't want icky commits.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency update
  • Security fix

Notes to Reviewers

  • Right now the hook duplicates the code-quality commands. We could invoke just test and just lint instead, at the cost of requiring just to be installed.
  • Should the command be just precommit or just pre-commit?

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

These can be be enabled by running `git config core.hooksPath .githooks`.

@storopoli storopoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5cf2638

Amazing work. Can you please do a sibling PR in alpenlabs/rust-template-workspace as well?

@storopoli storopoli merged commit 555c4bb into main Jun 13, 2026
10 checks passed
@storopoli storopoli deleted the william/pre-commit branch June 13, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants