fix using __AMDGCN_WAVEFRONT_SIZE - #307
Open
psychocoderHPC wants to merge 1 commit into
Open
Conversation
psychocoderHPC
commented
Jul 10, 2026
| sharedResult = 0u; | ||
|
|
||
| // wait that all shared memory is initialized | ||
| alpaka::syncBlockThreads(acc); |
Member
Author
There was a problem hiding this comment.
This synchronization is the reason why the old implementation already enforced that this method should be called with all threads in the thread block.
Contributor
|
Please rebase. |
Contributor
|
While you're at it, it would be great to split off the formatting things from the functional changes. But not blocking... only if time permits. |
fix alpaka-group#299 - refactor the code to use alpaka's warp size function - fix bug that `Scatter::getAvailableSlotsAccelerator()` was not mentioning the requirement to be called as collective method.
psychocoderHPC
force-pushed
the
fix-hipWavefrontIssue
branch
from
July 14, 2026 12:17
e5cdefe to
cb3e733
Compare
Member
Author
|
I removed the formatting changes. I forgot to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #299
Refactor the code to use alpaka's warp size function
fix bug that
Scatter::getAvailableSlotsAccelerator()was notmentioning the requirement to be called as a collective method.
merge update alpaka version #306 first (first 2 commits)