Add benchmarking - #304
Draft
saeedelsayed wants to merge 3 commits into
Draft
Conversation
chillenzer
marked this pull request as draft
June 22, 2026 15:24
chillenzer
reviewed
Jun 22, 2026
Comment on lines
+127
to
+137
| auto allocArray | ||
| = [] ALPAKA_FN_ACC(Acc const& acc, int x, Allocator::AllocatorHandle allocHandle) | ||
| { | ||
| arA<Acc> = static_cast<int**>(allocHandle.malloc(acc, sizeof(int*) * x)); | ||
| }; | ||
|
|
||
| auto freeArray | ||
| = [] ALPAKA_FN_ACC(Acc const& acc, Allocator::AllocatorHandle allocHandle) | ||
| { | ||
| allocHandle.free(acc, arA<Acc>); | ||
| }; |
Contributor
There was a problem hiding this comment.
This is approach is not ideal as this taints our nice and clean heap. Better handle the necessary memory externally with allocBuf (see "Allocate a buffer in device memory")
auto bufDevice = allocBuf<DataType, Idx>(device, extent);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.