Skip to content

Regenerate CLI from latest OAS - #13

Merged
sachyco merged 3 commits into
mainfrom
ctasada/regenerate-latest-oas
Aug 28, 2026
Merged

Regenerate CLI from latest OAS#13
sachyco merged 3 commits into
mainfrom
ctasada/regenerate-latest-oas

Conversation

@carlostasada

Copy link
Copy Markdown
Contributor

Summary

  • Sync OpenAPI specs and regenerate CLI clients, commands, and metadata
  • Remove market-data commands no longer present upstream (data index, data fixed-income)
  • Adapt order submit hook to CreateOrderRequest body rename
  • Pick up new flags (--order-id on account activity, --data-quality on corporate-actions)
  • Refresh docs, goldens, and integration coverage

Test plan

  • make check
  • make test-integration — suite passes except TestPositionCloseAll / TestPositionCloseAll_CancelOrders (paper account returns 403 closing leftover equity positions; unrelated to this regenerate)

Sync OpenAPI specs and regenerate clients, commands, and metadata.
Drop removed market-data index and fixed-income commands, and update
order submit for the CreateOrderRequest body rename.
@carlostasada carlostasada self-assigned this Aug 5, 2026
@carlostasada
carlostasada requested a review from sachyco August 5, 2026 09:55
@greptile-apps

greptile-apps Bot commented Aug 5, 2026

Copy link
Copy Markdown

Greptile Summary

The PR refreshes the Trading and Market Data OpenAPI contracts and regenerates the corresponding clients, types, operation metadata, and CLI command tree.

  • Adds OAS 3.1 nullable-type handling to the generator.
  • Replaces index commands with grouped fixed-income price and quote commands.
  • Adapts order submission to the renamed CreateOrderRequest type.
  • Adds account-activity and corporate-action flags and refreshes tests, fixtures, and documentation.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
cmd/generate/main.go Adds centralized OAS 3.0/3.1 schema-type and nullability parsing across generated types, requests, responses, and flags.
cmd/generate/commands.go Replaces index command registration with grouped fixed-income operations and applies schema-type parsing to body-field classification.
internal/cmd/order.go Updates the order preparation hooks to consume the renamed generated CreateOrderRequest without changing their behavior.
internal/cmd/commands.gen.go Regenerates the public CLI command tree and request mapping from the refreshed API specifications.
internal/api/trading_types.gen.go Refreshes generated Trading API models, including the renamed order-creation request.
internal/api/marketdata_types.gen.go Refreshes generated Market Data API models for the updated schemas and operations.
README.md Updates the documented market-data command areas to match the regenerated command tree.
test/integration/data_fixed_income_test.go Updates fixed-income integration coverage for the new grouped price and quote command paths.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
    OAS[Updated OpenAPI specs] --> Generator[CLI generator]
    Generator --> Types[Generated Go types]
    Generator --> Clients[Generated API clients]
    Generator --> Metadata[Operation and flag metadata]
    Metadata --> Commands[Generated CLI command tree]
    Types --> Commands
    Clients --> Commands
    Commands --> Tests[Goldens and integration tests]
Loading

Reviews (3): Last reviewed commit: "Regenerate CLI from latest OAS" | Re-trigger Greptile

@carlostasada
carlostasada marked this pull request as draft August 5, 2026 14:27
Add data fixed-income latest-prices/quotes and teach the generator OAS 3.1
nullable type arrays so request bodies keep working.
@carlostasada
carlostasada marked this pull request as ready for review August 11, 2026 06:56
Co-authored-by: Cursor <cursoragent@cursor.com>
@sachyco

sachyco commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

@greptile

@sachyco
sachyco merged commit 5360627 into main Aug 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants