Regenerate CLI from latest OAS - #13
Merged
Merged
Conversation
Sync OpenAPI specs and regenerate clients, commands, and metadata. Drop removed market-data index and fixed-income commands, and update order submit for the CreateOrderRequest body rename.
Greptile SummaryThe PR refreshes the Trading and Market Data OpenAPI contracts and regenerates the corresponding clients, types, operation metadata, and CLI command tree.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| cmd/generate/main.go | Adds centralized OAS 3.0/3.1 schema-type and nullability parsing across generated types, requests, responses, and flags. |
| cmd/generate/commands.go | Replaces index command registration with grouped fixed-income operations and applies schema-type parsing to body-field classification. |
| internal/cmd/order.go | Updates the order preparation hooks to consume the renamed generated CreateOrderRequest without changing their behavior. |
| internal/cmd/commands.gen.go | Regenerates the public CLI command tree and request mapping from the refreshed API specifications. |
| internal/api/trading_types.gen.go | Refreshes generated Trading API models, including the renamed order-creation request. |
| internal/api/marketdata_types.gen.go | Refreshes generated Market Data API models for the updated schemas and operations. |
| README.md | Updates the documented market-data command areas to match the regenerated command tree. |
| test/integration/data_fixed_income_test.go | Updates fixed-income integration coverage for the new grouped price and quote command paths. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
OAS[Updated OpenAPI specs] --> Generator[CLI generator]
Generator --> Types[Generated Go types]
Generator --> Clients[Generated API clients]
Generator --> Metadata[Operation and flag metadata]
Metadata --> Commands[Generated CLI command tree]
Types --> Commands
Clients --> Commands
Commands --> Tests[Goldens and integration tests]
Reviews (3): Last reviewed commit: "Regenerate CLI from latest OAS" | Re-trigger Greptile
carlostasada
marked this pull request as draft
August 5, 2026 14:27
Add data fixed-income latest-prices/quotes and teach the generator OAS 3.1 nullable type arrays so request bodies keep working.
carlostasada
marked this pull request as ready for review
August 11, 2026 06:56
Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
sachyco
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data index,data fixed-income)CreateOrderRequestbody rename--order-idon account activity,--data-qualityon corporate-actions)Test plan
make checkmake test-integration— suite passes exceptTestPositionCloseAll/TestPositionCloseAll_CancelOrders(paper account returns 403 closing leftover equity positions; unrelated to this regenerate)