fix: cleanup R2 object if DB insert fails during artifact upload#307
Open
jasoncobra3 wants to merge 1 commit into
Open
fix: cleanup R2 object if DB insert fails during artifact upload#307jasoncobra3 wants to merge 1 commit into
jasoncobra3 wants to merge 1 commit into
Conversation
Closes alookai#158 Orphaned R2 objects were created when bucket.put() succeeded but createArtifact() threw. Added try/catch to delete the R2 key on DB failure, preventing storage leaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #158
Orphaned R2 objects were created when bucket.put() succeeded but createArtifact() threw. Added try/catch to delete the R2 key on DB failure, preventing storage leaks.
What changed
Problem
When
bucket.put()succeeded butcreateArtifact()threw, the R2object was left orphaned in storage with no corresponding DB record.
Fix
Wrapped the DB insert and surrounding logic in a try/catch. On failure,
bucket.delete(r2Key)is called to clean up the orphaned R2 objectbefore re-throwing the original error.
Testing