Fix (#167) romania deviating files once in a while

[bart1]

For the rare cases the urls is 0300 we use the alternative format

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.66%. Comparing base (4b6a386) to head (cdf1c95).
⚠️ Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
R/get_pvol_ro.R	60.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   93.16%   91.66%   -1.50%     
==========================================
  Files          24       25       +1     
  Lines        1814     1896      +82     
==========================================
+ Hits         1690     1738      +48     
- Misses        124      158      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bart1]

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review. ✅ Project coverage is 92.88%. Comparing base (4b6a386) to head (0530338).
Files with missing lines Patch % Lines
R/get_pvol_ro.R 60.00% 6 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:

As far as i know it is not predictable when files with these names are produced therefore there is no test

[PietrH]

I think you could test this via mocking: https://testthat.r-lib.org/reference/local_mocked_bindings.html

You'd then locally redefine read_pvol_from_url_per_param to return a httr2_http_404 condition on your test query default url, but a value you can test for (TRUE or a string, or whatever) on the modified, expected new url.

I'm not sure you should. But you could.

Otherwise, looks good. I'd maybe rename the second urls object to a different symbol so I could compare the two more easily when debugging. But that's only a very minor nitpick.

Nice fix! Shame there isn't a more descriptive server response other than the 404! What would happen if the second url also returns a 404?

[bart1]

update urls

[bart1]

I think you could test this via mocking: https://testthat.r-lib.org/reference/local_mocked_bindings.html

You'd then locally redefine read_pvol_from_url_per_param to return a httr2_http_404 condition on your test query default url, but a value you can test for (TRUE or a string, or whatever) on the modified, expected new url.

Might be nice in the future

Nice fix! Shame there isn't a more descriptive server response other than the 404! What would happen if the second url also returns a 404?

It will just return a 404. which most likely means the server is down

[bart1]

@PietrH if you approve I can merge ;)