Skip to content

E1 — Auth & Accounts#114

Open
aloewright wants to merge 1 commit into
mainfrom
conductor/alo-120-e1-auth-accounts
Open

E1 — Auth & Accounts#114
aloewright wants to merge 1 commit into
mainfrom
conductor/alo-120-e1-auth-accounts

Conversation

@aloewright
Copy link
Copy Markdown
Owner

Closes ALO-120.

Summary

E1 was already largely shipped — email verification (ALO-128), password reset (ALO-129), profile (avatar/banner in R2), account settings + GDPR delete (ALO-132), and session management UI (ALO-133) all landed in earlier PRs. This PR closes the last in-scope gap: OAuth providers.

  • Wire better-auth socialProviders for Google + GitHub, gated on env vars (GOOGLE_CLIENT_ID/SECRET, GITHUB_CLIENT_ID/SECRET). Absent vars cleanly skip the provider so local dev / tests don't need real OAuth apps.
  • Add a shared <OAuthButtons /> component and surface it on Login + Signup. Uses signIn.social({ provider, callbackURL }) so the redirect dance is handled by better-auth.
  • Document the new secrets in wrangler.toml.
  • Tests: socialProviders is omitted when creds absent and wired correctly when both pairs are present.

Done-when checklist

  • Email verification (already shipped — ALO-128)
  • Password reset (already shipped — ALO-129)
  • Profile (display name, avatar in R2)
  • Account settings + delete (ALO-132)
  • OAuth (Google, GitHub) — this PR
  • Session management UI (ALO-133)
  • Profile data renders on channel page (Channel.tsx)

Test plan

  • npm test — 44 files / 493 tests pass
  • npm run lint — 0 warnings, AI Gateway guard clean
  • npm run type-check — clean
  • Manual: configure GOOGLE_* / GITHUB_* secrets, click "Continue with…" buttons, verify session round-trip

🤖 Generated with Claude Code

Wire better-auth socialProviders gated on env vars and surface
"Continue with Google/GitHub" buttons on Login + Signup. Providers
are skipped cleanly when credentials are absent so local dev and
tests don't need real OAuth apps.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 8, 2026 15:03
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@aloewright aloewright added the conductor Conductor-managed PR label May 8, 2026
@ecc-tools
Copy link
Copy Markdown
Contributor

ecc-tools Bot commented May 8, 2026

ECC bundle files are already tracked in this repository. Skipping generation of another bundle PR.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 8, 2026

Warning

Rate limit exceeded

@aloewright has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 41 minutes before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 586bf34a-92c7-4976-b89e-0970f10b6232

📥 Commits

Reviewing files that changed from the base of the PR and between 4d3c13f and 9c00c38.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (6)
  • src/auth/index.test.ts
  • src/auth/index.ts
  • src/frontend/components/OAuthButtons.tsx
  • src/frontend/pages/Login.tsx
  • src/frontend/pages/Signup.tsx
  • wrangler.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch conductor/alo-120-e1-auth-accounts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@aloewright
Copy link
Copy Markdown
Owner Author

Copilot review errored out with no actionable feedback. Re-requested review. CI is green (lint/type-check/test/build SUCCESS) and CodeRabbit passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conductor Conductor-managed PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants