read ActionInvoker/ActionHandler URLs from env with defaults#54
Merged
Conversation
burmajam
requested review from
cy303,
iStefo and
j-barriuso-alm-iberia
and removed request for
iStefo
…, error} response
iStefo
approved these changes
May 20, 2026
iStefo
left a comment
iStefo
left a comment
Contributor
There was a problem hiding this comment.
All good, only very minor things that caught my 👁️
Comment on lines
+44
to
+45
| @doc false | ||
| @spec _ets_opts(opts :: list()) :: list() |
Contributor
There was a problem hiding this comment.
I think you can extract these out of the if if you want to avoid the duplication
| @spec execute( | ||
| base_name :: atom(), | ||
| target_api :: atom(), | ||
| Request.t(), |
Contributor
There was a problem hiding this comment.
this one misses the argument name, is that by choice?
Collaborator
Author
There was a problem hiding this comment.
yes, type is self-explanatory imo
| @spec execute( | ||
| base_name :: module(), | ||
| target_api :: atom(), | ||
| Request.t(), |
Contributor
There was a problem hiding this comment.
Same as in Connection Manager
burmajam
force-pushed
the
feature/local-mesh
branch
from
32907f1 to
2d3bcb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.