docs: clarify CoreDNS version is tied to plugin.cfg#30
Merged
davidpoblador merged 1 commit intomainfrom Apr 4, 2026
Merged
Conversation
The COREDNS_VERSION build arg is not freely overridable because plugin.cfg is version-specific and checked in. Update the Dockerfile with a comment explaining the coupling, and replace the misleading "Build arguments" README section with upgrade instructions. Closes #22 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COREDNS_VERSIONmust match the upstream versionplugin.cfgis based onCOREDNS_VERSIONwas freely overridable) with an "Upgrading versions" section that documents the correct upgrade procedure--build-argcommand to showCOREDNS_TAILSCALE_VERSION(the one that actually can be overridden independently)Closes #22
Test plan
#upgrading-versionsanchor) render correctly on GitHub🤖 Generated with Claude Code