Fix delegate_editor: preserve-caught-error lint, stale test, and misleading 404 messages - #163
Merged
Merged
Conversation
… readFile's rethrow
…ence in the tool description (trimmed in #162); the underlying no-PR-merge behavior is still enforced in code, just no longer restated in the description text
…uble-check the path" (it has no tool to do so) and stop nudging it toward assuming a missing path means a new file should be created. Both now instruct the agent to stop and report the exact path as unresolved instead of guessing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines three fixes, all green on CI:
{ cause: err }to the rethrown error inreadFile's 404 branch (fixes the pre-existingpreserve-caught-errorfailure on main).test/editor-tools.test.jsto stop asserting the "CANNOT open, approve, or merge pull requests" sentence, which was intentionally trimmed from the delegate_editor description in Trim delegate_editor tool description #162. The underlying no-PR-merge behavior is unchanged, just no longer restated in the description text.read_fileandwrite_file(replacements mode) 404 errors ineditor_tool_functions.js. The old messages told the agent to "double-check the path" despite it having no directory-listing/search tool to do so, and nudged it toward assuming a missing path means a new file should be created. Both now instruct the agent to stop and report the exact path as unresolved instead of guessing or defaulting to file creation.