Skip to content

feat(web): the item detail's bar and icon buttons, the editor's fixed bar and the generator in a dialog (D254) - #188

Open
allisson wants to merge 1 commit into
mainfrom
feat/d254-item
Open

allisson wants to merge 1 commit into
mainfrom
feat/d254-item

Conversation

@allisson

Copy link
Copy Markdown
Owner

The fourth D254 task: the item detail and the editor.

Item detail

  • Edit is the primary button, beside "More actions" (the "…" popover of D245).
  • On a field that is not secret, Copy and Open are icon buttons, each named "Copy: " or "Open: " and with a tooltip. Show and Copy on a secret keep their icon and visible text (§13.7).
  • History is also a link at the detail's foot, outside the trash, as in the menu.
  • Field rows were already divided inside their card (D247).

Editor

  • Cancel and Save sit in a bar fixed at the bottom of the pane. On a phone the bar sticks to the screen's scroll and its buttons are full width.
  • The generator opens from an icon button ("Generate") in the password field, in a modal dialog on tablet and desktop and a bottom sheet on a phone. Settings, entropy and "Use this password" are unchanged, and Cancel or Escape closes it. Ctrl/⌘+Enter does not save from inside a dialog.
  • Modal holds the native <dialog>, its sheet and its Escape; ConfirmDialog is built on it.
  • Icons dices and external-link, copied from Lucide 1.61.0.

Tests

  • item-detail.spec.ts: the icon buttons' name, tooltip and link.
  • Specs that opened "More actions" before History now click History at the foot. Specs that left the editor with the generator open close it first with Escape. The screen-reader snapshot follows the new Cancel, Save order.
  • pnpm run ci passes. The whole Playwright suite passes on Chromium, run locally. Firefox and WebKit run in CI.

🤖 Generated with Claude Code

… bar and the generator in a dialog (D254)

Edit is the detail's primary button beside "More actions"; Copy and Open on a field that is not
secret are icon buttons with an accessible name and a tooltip, and History is also a link at the
detail's foot. The editor's Cancel and Save sit in a bar fixed at the bottom of the pane. The
generator opens from an icon button in the password field, in a modal dialog, a bottom sheet on a
phone, with the same settings, entropy and "Use this password". Icons `dices` and `external-link`
copied from Lucide 1.61.0.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant