Repository navigation
feat(web): a wizard for pairing, joining, re-admission and sync (D253) - #182
Merged
Merged
Conversation
One step at a time under "Step N of M · name" and a bar, what to do on the other device in a fixed box, and Cancel while there is something to cancel. No Back between steps: a failure says why and starts again from step 1. Preparing, connecting, sending and merging wait within their step. "Same network only" and the STUN list move into "Advanced options", closed on step 1 unless the stored list cannot be read. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second part of the v0.7.1 work (D253): the pairing and sync screens become a wizard, after the v0.7.0 hands-on test found them unclear about where the user stands and what the other device expects.
What changes
Wizard(ui/Wizard.tsx): "Step N of M · name" with a bar, the step's content, a fixed "On the other device" box saying what to do there, and Cancel while there is something to cancel. No Back between steps: a failure says why and "Start again" returns to step 1. Preparing, connecting, sending and merging are waiting states within their step, not steps.Tests
openAdvancedandcheckSameNetworkine2e/create.ts, used by the 31 places that checked "Same network only".pairing.spec.tschecks the steps on both devices, the "On the other device" box and the closed advanced options.onboarding.spec.tschecks the join's step 1.pnpm run cigreen. Playwright on Chromium, Firefox and WebKit: 534 passed, 23 skipped, 1 failed (erase.spec.tson WebKit, where the start screen took more than 5 s under the full run's load). That spec then passed 9 of 9 alone.Docs
docs/overview.md: D253, which also sets the steps of the seven other flows that come next (create, restore, reset the password, regenerate the phrase, re-found, merge, import). It amends D203, D207, D216 and D234.docs/roadmap.md: the device wizard task ticked.🤖 Generated with Claude Code