Repository navigation
feat(web): keyboard and length slider, the last area of Phase 7b (D251) - #179
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last area of Phase 7b (D244): keyboard and the generator's length slider.
What changes
aria-keyshortcutsand its tooltip.autocomplete="off"and no spellcheck, like every control (D174, D176).Tests
shortcuts.test.ts: the movement keys and the save shortcut, with their modifiers.keyboard.spec.ts: a new D251 test: Ctrl/⌘+Enter from the notes, ↓/J/↑/K through the list and back to the search, Esc, and the slider and field in step.pnpm run cigreen. Playwright on Chromium, Firefox and WebKit: the full run gave 526 passed, 23 skipped, 6 failed.form-history.spec.tscaught the slider withoutautocomplete="off"(fixed); the other three were WebKit runs ofpairing.spec.tsandstorage-state.spec.ts. After the fix,form-history,keyboard,storage-stateand the failedpairingtest passed 36 of 36.Docs
docs/overview.md: D251.docs/roadmap.md: the keyboard task ticked.🤖 Generated with Claude Code