Repository navigation
feat(web): feedback, the sixth area of Phase 7b (D250) - #178
Merged
Merged
Conversation
Toast region, bottom sheet on a phone, the empty vault's first steps, and an error boundary that locks the vault before its failure screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sixth area of Phase 7b (D244): feedback.
What changes
role=status), mounted with the vault shell, at the bottom and above the phone's navigation. It says "Saved.", "Moved to the trash." and "Restored.", and carries the copy message that used to sit beside each Copy button. A new toast replaces the last one; each goes after 5 s; no entrance underprefers-reduced-motion; it holds no secret and goes on lock.<dialog>at the bottom, full width, buttons 44 px tall with the action first. Wider screens keep the centered dialog. No drag handle, and no confirmation added to Move to trash (the trash restores it).importfocus) and "Pair a device". A vault that cannot be written leaves out the item and the import.Tests
e2e/feedback.spec.ts: the first steps and where they lead; the toasts for save, copy, trash and restore, with no animation under reduced motion; the sheet on a phone (full width, at the bottom, action first, 44 px) and the dialog wider; a render error that locks, clears the clipboard and offers Reload.screen-reader.spec.tsfollows the checklist, the toast and the sheet's button order;backup.spec.tsandrecovery-phrase.spec.tsscope their status to the main region; three specs look for "First steps" instead of "No items yet.".pnpm run cigreen. Playwright on Chromium, Firefox and WebKit: the full run gave 514 passed, 23 skipped, 15 failed (the specs above). The fixed specs pluskeyboard,axe,motionandlayoutthen passed 67 of 67.Docs
docs/overview.md: D250.docs/roadmap.md: the feedback task ticked.docs/security-invariants.md: the error boundary test under CRYPTO-INV-010.🤖 Generated with Claude Code