fix: incorrectly formatted URLs#364
Conversation
|
It has been almost a year since I filed this pull request, yet not a single word from maintainers. Thousands of projects still rely on this tool, yet doing the bare minimum of keeping the project alive is too hard? Come on... |
Life has got in the way for most of us. And a project of this size is hard to maintain solo when life throws plenty of stuff at you (and you don't want to burn out again due to coding for a living, and then on the side, whilst having many other responsibilities). If you still think this PR helps, then I'm happy to reopen it and merge it. |
|
No worries, haven't tested it though since PR was filed |
|
Hey there @KibbeWater, life happens, and I think the original maintainer team didn't have the bandwidth to continue working on this project. The good news is that we are building a new maintainer team here. Right now, we're trying to update all of the dependencies and tighten down security. We won't be able to get to bugs until we can safely release a new version, but we are getting there. If you happen to have bandwidth to help, please feel free to chime in on an issue or pr! This pr is in our pipeline once everything is updated! If not, no worries, thanks for your patience as we get to know a very large and used project!! ❇️ |
3 participants
What: Fixed a bug where URLs may be malformed and an additonal bug which improved CLS on generated files
Why: Newer GitHub URLs may come with a ?v=4 query already, making these URLs malformed causing errors and incorrect sizings. This will size images properly, saving on data and web load times. There is also a fix to reduce the CLS by defining the width and height of the image.
How: URLs are being formatted with the URL class to ensure URL safety.
Checklist: