Add locale option and sort using locale (closes #349)#350
Open
SmallhillCZ wants to merge 1 commit intoall-contributors:mainfrom
Open
Add locale option and sort using locale (closes #349)#350SmallhillCZ wants to merge 1 commit intoall-contributors:mainfrom
SmallhillCZ wants to merge 1 commit intoall-contributors:mainfrom
Conversation
Member
Nope, aside from when the lines are too long (since there's a max length for rows).
Yeah, the docs are in https://github.com/all-contributors/all-contributors.
Yes, please. |
Author
|
Thanks, I will have a look into this next month, this one is too full already ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Sorting is made to be locale aware
Why: sorting of non-ACII languages does not work correctly, see #349
How:
contributorsSortLocaleoption is added to CLI to control which locale is going to be used for alphabetic sortingString.localeCompareinstead of_.sortByto enable locale aware sortingChecklist:
TODOs: