[CRD] fix the grid layout on the dashboard#9771
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
WalkthroughDesktop layouts in DashboardLayout and SpaceExplorer are changed to a 12-column grid applying contentColumnClass; RecentSpaces adds a configurable maxItems and uses it for skeletons and visible card slicing; sidebar.navigation i18n keys were added across locales. ChangesLayout, RecentSpaces, and localization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/crd/components/dashboard/DashboardLayout.tsx`:
- Line 89: Replace the hardcoded aria-label on the nav in DashboardLayout.tsx
with a localized call to t() from the 'crd' namespace (e.g., obtain t via
useTranslation('crd') in the component and use
aria-label={t('dashboard.navigation')}), and add the corresponding
"dashboard.navigation" key and translations to the CRD locale JSON/YAML files;
ensure the import/use of useTranslation('crd') (or existing i18n helper) is
present and remove the literal "Dashboard navigation" text.
In `@src/crd/components/space/SpaceExplorer.tsx`:
- Around line 234-253: The filter chip buttons rendered where
setPrivacyFilter('all') and setTypeFilter('all') are called lack
keyboard-visible focus styles; update the className of both button elements used
for privacy and type filters to include focus-visible utility classes (e.g.,
focus-visible:outline-none and a focus-visible:ring and ring color such as
focus-visible:ring-2 focus-visible:ring-primary or focus-visible:ring-ring) so
keyboard users get a clear focus indicator when tabbing to the buttons.
- Around line 285-291: The <ul> container rendering displayedSpaces should
include an explicit role attribute for accessibility; update the UL element that
uses className={cn('grid gap-6 list-none p-0 m-0', gridCols)} and
aria-label={t('spaces.spacesLabel')} to also include role="list" so the
collection containing the <li> items and <SpaceCard> children (props: space,
onParentClick) follows the CRD guideline requiring role="list" on list
containers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f39dee46-f23a-4547-9214-36c822558d65
📒 Files selected for processing (2)
src/crd/components/dashboard/DashboardLayout.tsxsrc/crd/components/space/SpaceExplorer.tsx
Collaborator
Author
|
@coderabbitai resolve |
Contributor
✅ Actions performedComments resolved. Approval is disabled; enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse the layout from Space page on the dashboard and explore spaces. Fixes the mismatch between the topbar and the content.
Summary by CodeRabbit
Refactor
New Features
Localization / Accessibility