Skip to content

test(vidur): cover AICB KV cache save predictions - #295

Open
catyans wants to merge 1 commit into
aliyun:masterfrom
catyans:fix/aicb-kv-cache-save-regression
Open

test(vidur): cover AICB KV cache save predictions#295
catyans wants to merge 1 commit into
aliyun:masterfrom
catyans:fix/aicb-kv-cache-save-regression

Conversation

@catyans

@catyans catyans commented Jul 23, 2026

Copy link
Copy Markdown

Summary

Add a focused regression test for the AICB execution-time predictor to ensure it always publishes the attn_kv_cache_save table consumed by Vidur batch execution.

This protects the failure reported in #266. The current master implementation contains the prediction after the SimAI 1.6 merge, but the behavior had no automated coverage and the issue remains open.

Test coverage

  • verifies the AICB table contains attn_kv_cache_save;
  • verifies every token count in the configured prediction range is populated;
  • verifies generated execution times are non-negative.

Validation

  • git diff --check
  • Python 3.11 remote H20 syntax smoke for the predictor and regression test (ede4acc)

A full pytest run requires the Vidur Python dependency environment; the remote H20 base OS does not carry those packages.

Fixes regression coverage for #266.

@CLAassistant

CLAassistant commented Jul 23, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Signed-off-by: Yanshu WANG <wangyanshu2016@gmail.com>
@catyans
catyans force-pushed the fix/aicb-kv-cache-save-regression branch from ede4acc to 82d8af3 Compare July 23, 2026 10:32
@catyans

catyans commented Jul 23, 2026

Copy link
Copy Markdown
Author

CLA follow-up: rewrote the single commit metadata (content unchanged) so author, committer, and Signed-off-by use the email linked to GitHub user catyans. New head: 82d8af3a.

@catyans

catyans commented Jul 31, 2026

Copy link
Copy Markdown
Author

recheck

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a regression test to prevent a recurrence of SimAI issue #266 by ensuring the AICB execution-time predictor publishes attn_kv_cache_save predictions across the configured token range.

Changes:

  • Introduces a new pytest regression test validating attn_kv_cache_save is present in AICB compute predictions.
  • Asserts predictions are populated for every token count in the range and that values are non-negative.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +3 to +7
from types import SimpleNamespace

from vidur.execution_time_predictor.sklearn_execution_time_predictor import (
SklearnExecutionTimePredictor,
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants