test(vidur): cover AICB KV cache save predictions - #295
Conversation
|
|
Signed-off-by: Yanshu WANG <wangyanshu2016@gmail.com>
ede4acc to
82d8af3
Compare
|
CLA follow-up: rewrote the single commit metadata (content unchanged) so author, committer, and Signed-off-by use the email linked to GitHub user |
|
recheck |
There was a problem hiding this comment.
Pull request overview
Adds a regression test to prevent a recurrence of SimAI issue #266 by ensuring the AICB execution-time predictor publishes attn_kv_cache_save predictions across the configured token range.
Changes:
- Introduces a new pytest regression test validating
attn_kv_cache_saveis present in AICB compute predictions. - Asserts predictions are populated for every token count in the range and that values are non-negative.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from types import SimpleNamespace | ||
|
|
||
| from vidur.execution_time_predictor.sklearn_execution_time_predictor import ( | ||
| SklearnExecutionTimePredictor, | ||
| ) |
Summary
Add a focused regression test for the AICB execution-time predictor to ensure it always publishes the
attn_kv_cache_savetable consumed by Vidur batch execution.This protects the failure reported in #266. The current master implementation contains the prediction after the SimAI 1.6 merge, but the behavior had no automated coverage and the issue remains open.
Test coverage
attn_kv_cache_save;Validation
git diff --checkede4acc)A full pytest run requires the Vidur Python dependency environment; the remote H20 base OS does not carry those packages.
Fixes regression coverage for #266.