fix(page-controller): keep _blank link clicks in current tab#441
Open
Gujiassh wants to merge 1 commit intoalibaba:mainfrom
Open
fix(page-controller): keep _blank link clicks in current tab#441Gujiassh wants to merge 1 commit intoalibaba:mainfrom
Gujiassh wants to merge 1 commit intoalibaba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clickElement()handle<a target="_blank">links in the current tab_selffor the click, then restore the original target attributeProblem
Issue #432 reports that
_blanklinks and cross-tab flows break Page Agent execution.Validation
npx tsc --noEmit -p packages/page-controller/tsconfig.jsonCloses #432