fix(page-agent): wrap demo bundle helpers in local scope#430
Open
voidborne-d wants to merge 1 commit intoalibaba:mainfrom
Open
fix(page-agent): wrap demo bundle helpers in local scope#430voidborne-d wants to merge 1 commit intoalibaba:mainfrom
voidborne-d wants to merge 1 commit intoalibaba:mainfrom
Conversation
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
page-agent.demo.jschunk in an extra function scope during bundlingWhy
Issue #426 reports
"St has already been declared"after re-injecting the built script on some pages.I traced this to helper variables emitted before the current IIFE prelude, for example:
Those top-level helpers can leak into the page realm and collide when the same bundle is injected again. Wrapping the final emitted chunk gives the whole bundle, including helper prelude code, its own local scope.
Validation
npm install --ignore-scriptsnpm run build:demo(() => {