Open
Conversation
Reset AbortController and status when stop() is called. Agent can now be reused for subsequent tasks. Changes: - Check if already stopped to prevent double-abort - Reset status to 'idle' - Create new AbortController for next task
linked-danis
force-pushed
the
pr1-reusable-agent
branch
from
a4a84b0 to
00fbf2d
Compare
gaomeng1900
reviewed
Mar 16, 2026
|
|
||
| /** Stop the current task. Agent remains reusable. */ | ||
| stop() { | ||
| if (this.#abortController.signal.aborted) return // Already stopped |
Collaborator
There was a problem hiding this comment.
Doesn’t seem necessary.
gaomeng1900
reviewed
Mar 16, 2026
| this.pageController.hideMask() | ||
| this.#abortController.abort() | ||
| this.#setStatus('idle') | ||
| this.#abortController = new AbortController() |
Collaborator
There was a problem hiding this comment.
Doesn’t seem necessary.
Collaborator
|
Maybe only keep Are you sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset AbortController and status when stop() is called. Agent can now be reused for subsequent tasks.
Changes:
What
Brief description of changes.
Type
Testing
Closes #(issue)
Requirements / 要求