fix(viewer): stack suggested code panels - #739
Open
Linxiushen wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 1 selected item(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Display the existing-code and suggested-change panels as a single vertical stack at every viewport size. Each snippet now gets the full comment width, making longer lines easier to compare and removing the redundant mobile-only grid override.
Type of Change
How Has This Been Tested?
go vet ./...At 1265px, both panels render at the same 1026px width on separate rows. At a 390px viewport, they remain stacked within the comment card without panel overflow.
go test ./internal/vieweralso reaches three existing permission-mode assertions that are not portable to Windows (TestHandleRepos_PermissionDenied,TestDiscoverRepos_SkipsUnreadableSubdir, andTestListSessions_SkipsUnreadableFiles). The focused Viewer rendering tests pass.Checklist
go fmt,go vet)Related Issues
Closes #733