feat(llm): add per-model reasoning effort - #676
Open
allenxu09 wants to merge 2 commits into
Open
Conversation
Contributor
|
🔍 OpenCodeReview found 5 issue(s) in this PR.
|
allenxu09
marked this pull request as ready for review
August 2, 2026 03:58
Author
|
@lizhengfeng101 ping |
|
这是一个刚性需求,需要实现。 |
Author
|
@MuoDoo @lizhengfeng101 ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_settingsreasoning_effortreasoning.effortoutput_config.effortWhy
Reasoning effort is model-specific, and each supported protocol uses a different request shape. Previously OCR had no first-class way to select it, so users had to rely on global
extra_bodyoverrides that did not follow model switches cleanly.User impact
Users can select an effort while adding or switching models, set it with
ocr config set reasoning_effort <value>, override it per run with--reasoning-effortorOCR_LLM_REASONING_EFFORT, and reset to the provider default without removing other model settings.Validation
go test ./internal/llm ./internal/agent./cmd/opencodereviewgo vet ./internal/llm ./internal/agent ./cmd/opencodereviewIdleView.tsx)npm run test:github-actions