fix: remove committed developer-local 'output' symlink - #42
Open
armatrix wants to merge 1 commit into
Open
Conversation
The tracked 'output' entry is a symlink pointing to a developer's
local machine path (/Users/hoshinoren/.../tron-comic/output), which
is broken on any other machine and crashes backend startup:
os.makedirs("output", exist_ok=True) in src/apps/comic_gen/api.py
raises FileExistsError because the path exists but is not a directory.
'output/' is already in .gitignore (line 93); the runtime creates the
directory itself, so nothing needs to be tracked here.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 #41 中的问题 1：移除被提交进仓库的
output软链。该条目指向开发者本机路径（
/Users/hoshinoren/.../tron-comic/output），在任何其他机器上都是死链，导致后端启动时os.makedirs("output", exist_ok=True)抛FileExistsError（路径存在但不是目录），uvicorn 直接退出。.gitignore第 93 行已有output/规则，删除跟踪后不会再被意外提交src/apps/comic_gen/api.py启动时会自行创建该目录，无需在仓库中保留任何占位#41 中的问题 2（lockfile 指向内网 registry）建议由维护者在公网环境重新生成 lockfile 修复，不在本 PR 范围内。