feat: add useTimer - #2626
Closed
jacksyk wants to merge 1 commit into
Closed
Conversation
|
|
Open
Collaborator
|
很好的一个 hook，这个 hook 的发布，意味着，useCountDown 就可以不需要，这将是一个 breakchange，所以我建议把这个放到 v4 分支进行发布，所以你看看你重新提一个 pr ，不要合到 master 了，合到 v4 分支 |
Author
|
好的 |
Collaborator
|
interval 这个属性 useCountDown 是有的，这个没了，也需要补一下 |
Author
|
这个不好支持吧？为了达到精准性，目前这个hooks用的REA的回调去执行，也就意味着每一次重绘之前都会set一下，设置了interval只能去控制渲染时机了，这样又会失去hooks的精准性 |
Author
|
新pr #2662 |
Open
Author
|
感觉用到的interval场景应该对时间要求也不高，这个hooks的主要目的还是为了实现一个精准性问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add useTimer hooks