Repository navigation
Upgrade async-profiler to 4.6 - #3281
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the bundled async-profiler from 4.4 directly to 4.6. Reference #3267 for context; this is an independent upgrade from current master.
Replace Linux x64, Linux arm64, and universal macOS native libraries with the official non-debug release artifacts, verified against the release asset SHA-256 digests.
Sync the existing four Java API classes with tag
v4.6, commit557276c2950c14a5ad7073e2bef5a16616309247, includingdumpOtlp(Counter).Keep the existing
meminfoaction for terminal/HTTP/MCP callers, but translate it to nativemetrics. Nativememinfowas already absent in 4.4; the result now contains Prometheus metrics while retaining thememinfomodel action. Update its documentation and add a regression test.Add native tests in isolated JVMs for version/loading, wall sampling and thread-name filtering, both collapsed/OTLP counters, HTML/tree and JFR output, stopping, and class-loader collection. They run through the existing Java CI on supported platforms.
Update Chinese/English documentation for macOS 11+,
ithread/xthreadreplacing thread-ID filters, combined HTML views, the removed upstream HTTP server, and actual version/metrics output.Use the repository's Maven Wrapper for every JavaCI build, pinning Maven to 3.9.9 (including
mvnw.cmdon Windows). This preserves the existing JDK 8tools.jardependency behavior after runner-provided Maven 3.10.0 stopped activating the wrapper dependency's file-based profile.The Java API scope was re-evaluated against 4.6. Upstream fixed #1811 and #1818 by avoiding eager
Recordinginitialization when the native library loads. ExplicitRecordinguse still establishes a JNI global reference. Arthas does not use the Java Span API, so keep its existing API subset and document whyAgent,Recording, andSpanare not bundled. Normal profiling and JFR do not require them.Validation:
./mvnw -V -B -ntp -pl core -am clean package -DargLine=-XX:+StartAttachListener— 341 tests passed, no failures/errors/skips. Workflow YAML parsing andgit diff --checkpassed../mvnw -B -ntp -pl core,agent,client,boot,packaging -am clean package -DargLine=-XX:+StartAttachListener -Darthas.site.frontend.skip=true— 385 tests passed, no failures/errors/skips. The site frontend was built separately withnpm --prefix site run docs:build— all 156 pages built.ArthasClassloaderchecks passed for CPU/HTML, CPU JFR, wall/allocation/monitor-lock JFR, and collection after stopping. JDK 21jfrsyncpassed. Parsed the recordings and checked their event counts.git diff --checkpassed.Linux native runtime was not tested locally; the new native tests cover Linux x64 in the existing CI matrix. The Linux GLIBC symbol requirements match the previous bundled libraries (x64: up to 2.16; arm64: 2.17). The full-project/JDK 17+ integration suite was not run locally.
Native library SHA-256:
1aa55af4645fafb7b70fe78b8bcc8d32a1a2fce1a278ce04318224df68694fb245895af951d172126819552f5e2762b1a71c4db2a95ab8def791becb9ce7e35dbf3f48291999c1d97ae7e7102bc75f458eec91f5e70f2c23c032c24f9a575c8b