Repository navigation
Fix MCP callback binding for parameter aliases - #3279
Open
hutiefang76 wants to merge 1 commit into
Open
hutiefang76 wants to merge 1 commit into
hutiefang76 wants to merge 1 commit into
Conversation
Use the same parameter name resolution for the advertised input schema, required argument checks and reflective invocation. Otherwise valid JSON using a JsonProperty alias is rejected or bound as null.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3278.
The public callback API can advertise a parameter as
message_textthrough@JsonProperty, then reject{"message_text":"hello"}because validation and binding still look up the Java namemessage. Optional aliased arguments are silently passed asnull.Reuse the schema generator's existing parameter-name resolver for both required checks and argument binding. Missing-argument errors now report the advertised name too. Unannotated parameters, empty aliases and
ToolContextinjection keep their existing behavior.This concerns callbacks constructed with
ToolDefinitions.from(Method)andDefaultToolCallback.builder(). The built-in agent tools do not declare parameter aliases; this does not change their configuration or fix unrelatedtt/traceissues. The README includes a public API example and Chinese/English guidance.Validation on JDK 8:
./mvnw -B -pl arthas-mcp-server -am clean verify: all 20 tests pass, including the seven new cases; no failures, errors or skips.git diff --checkpasses.