Repository navigation
fix: show the full thread id in the thread table - #3274
Merged
hengyunabc merged 1 commit intoOct 9, 2026
Merged
Conversation
The ID column weight was 1, so at the default width of 80 Overflow.HIDDEN kept only two characters. 100 and 101 both rendered as 10. Borrow weight from the NAME column, which is already clipped, and leave the other columns unchanged. Fixes alibaba#3270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threadanddashboardgive the ID column weight 1. At the default width of 80,Overflow.HIDDENkeeps only two characters, so 100 and 101 both render as10and the stack cannot be matched to a thread.The ID column borrows weight from NAME, which is already clipped. The other columns keep their weights. A short id such as
-1still uses the previous layout.Fixes #3270
Test plan
JAVA_HOME=11 ./mvnw -pl core test -Dtest=ViewRenderUtilTest -Dsurefire.failIfNoSpecifiedTests=false100123rendered as10100123,100, and101are fully visible;-1and theDAEMONcolumn still renderJAVA_HOME=11 ./mvnw -pl core test— ViewRenderUtilTest passed with the module suite.FileUtilsTest.testOpenOutputStreamCannotWritefailed because this environment can write the fixture path; that test is unrelated to this change.