fix(tokenless): address code review findings across schema, env-check, hooks, and plugin#538
Merged
Merged
Conversation
…, hooks, and plugin
- schema_compressor: prevent UTF-8 panic on CJK text by using
floor_char_boundary before slicing
- env_check version_ge: handle v-prefixed (v22.1.0) and build-suffix
(1.2.3-rc1) version strings in both Rust and shell
- env_check find_spec_path: return error instead of non-existent
fallback path
- compress_response/toon: route TOON encoding through
tokenless compress-toon for proper stats recording and size check
- openclaw plugin: same TOON routing fix with session/tool-use context
- tool_ready file_write: fix tmpfile leak and broken perm_missing
logic in permission check
- tool_ready phase 3: re-check version_low and recommended deps
after auto-fix; use RECOMMENDED_MISSING_LIST in PARTIAL message
- extract_missing_cmd: match bash error format ("bash: line 1: foo:
command not found") alongside zsh format
- stats recording: rename after_compact → output_text to record
actual output instead of intermediate compact form
Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
bugfix #
Type of Change
Scope
cosh(copilot-shell)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)Checklist
cosh: Lint passes, type check passes, and tests passsec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpasspackage-lock.json/Cargo.lock)Testing