feat(sec-core): add hermes-plugin framework and add code scan support for hermes#536
Open
yangdao479 wants to merge 3 commits into
Open
feat(sec-core): add hermes-plugin framework and add code scan support for hermes#536yangdao479 wants to merge 3 commits into
yangdao479 wants to merge 3 commits into
Conversation
… for hermes Signed-off-by: yizheng <YiZheng.Yang@linux.alibaba.com>
github-actions
Bot
added
component:sec-core
Signed-off-by: yizheng <YiZheng.Yang@linux.alibaba.com>
Signed-off-by: yizheng <YiZheng.Yang@linux.alibaba.com>
yangdao479
force-pushed
the
feature/agent-sec-core/hermes-support
branch
from
136df39 to
047733a
Compare
edonyzpc
reviewed
May 15, 2026
Collaborator
There was a problem hiding this comment.
hermes-plugin 目录没有在 rpm 打包里面
Collaborator
Author
There was a problem hiding this comment.
故意为之， 后续更新。不和build-all的逻辑同步开发
edonyzpc
reviewed
May 15, 2026
|
|
||
| ```bash | ||
| # 从 agent-sec-core 目录执行 | ||
| uv run --project agent-sec-cli pytest tests/unit-test/hermes-plugin/ -v |
Collaborator
There was a problem hiding this comment.
hermes-plugin/README.md 里的测试路径 pytest tests/hermes-plugin/ ，两个不一致
edonyzpc
reviewed
May 15, 2026
Comment on lines
13
to
20
| # 1. agent-sec-cli/pyproject.toml (project.version) | ||
| # 2. agent-sec-cli/Cargo.toml (package.version) | ||
| # 3. agent-sec-cli/src/agent_sec_cli/__init__.py (__version__) | ||
| # 4. agent-sec-cli/src/agent_sec_cli/cli.py (fallback version) | ||
| # 5. openclaw-plugin/package.json ("version" field) | ||
| # 6. openclaw-plugin/openclaw.plugin.json ("version" field) | ||
| # 7. cosh-extension/cosh-extension.json ("version" field) | ||
| # 8. Lock files: Cargo.lock, uv.lock, package-lock.json (auto-regenerated) |
edonyzpc
reviewed
May 15, 2026
| return {"action": "block", "message": msg} | ||
| return None | ||
|
|
||
| logger.info(f"PASS tool={tool_name} code={code[:120]}") |
Collaborator
There was a problem hiding this comment.
scan-code 输出 verdict=error 时被当作 PASS 静默放行
edonyzpc
requested changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
closes #
Type of Change
Scope
cosh(copilot-shell)sec-core(agent-sec-core)skill(os-skills)sight(agentsight)tokenless(tokenless)Checklist
cosh: Lint passes, type check passes, and tests passsec-core(Rust):cargo clippy -- -D warningsandcargo fmt --checkpasssec-core(Python): Ruff format and pytest passskill: Skill directory structure is valid and shell scripts pass syntax checksight:cargo clippy -- -D warningsandcargo fmt --checkpasstokenless:cargo clippy -- -D warningsandcargo fmt --checkpasspackage-lock.json/Cargo.lock)Testing
Additional Notes