Skip to content

Conversation

@icodening
Copy link
Contributor

Describe what this PR does / why we need it

support custom traffic shaping controller

Does this pull request fix one issue?

ref #3189

Describe how you did it

using TrafficShapingControllerFactory spi to create instance

Describe how to verify it

Special notes for reviews

@LearningGp LearningGp added to-review To review area/flow-control Issues or PRs related to flow control labels Sep 15, 2025
Copy link
Collaborator

@uuuyuqi uuuyuqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. By the way, could you add some unit tests? The new version of ci does have coverage checks

@z-soulx
Copy link

z-soulx commented Oct 16, 2025

Describe what this PR does / why we need it

support custom traffic shaping controller

Does this pull request fix one issue?

ref #3189

Describe how you did it

using TrafficShapingControllerFactory spi to create instance

Describe how to verify it

Special notes for reviews

Hi @icodening , thank you so much for this PR — I think your implementation idea is really great!
I’m also very interested in getting this feature officially supported as soon as possible.
If you’re okay with it, I’d like to fork your branch and add some unit tests to help move it forward.
I’ll make sure to credit your original contribution in the new PR.

Thanks again for your work!

@z-soulx
Copy link

z-soulx commented Oct 17, 2025

#3189

#3567 Hi,@uuuyuqi — when you have time, please help take a look at this PR.
It’s a follow-up to @icodening’s earlier work, with some enhancements and clarifications.

@LearningGp
Copy link
Collaborator

We'll continue discussing this issue in PR #3567.

@LearningGp LearningGp closed this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/flow-control Issues or PRs related to flow control to-review To review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants