fix(cli): three-valued start status prevents destructive restart after health timeout - #446
Merged
Merged
Conversation
…r health timeout
After a health-poll timeout, the Connect box said "Start the server:" while
the spinner had just said "the container keeps starting in the background."
Following that instruction kills the still-syncing container and restarts
from scratch. The root cause: offerDockerRun returned boolean, collapsing
"never started" and "started but still coming up" into the same false.
Widen the return to StartStatus ("running" | "starting" | "not-started")
and thread it through both connect-message builders. The "starting" variant
shows "starting in the background — check progress: docker logs" instead of
the start command that would re-create the container.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![umm-actually[bot]](https://avatars.githubusercontent.com/in/4233716?s=60&v=4){kind=small}
|
umm-actually re-reviewed at No new findings (2 tracked finding(s) across all runs). umm-actually · deepseek/deepseek-v4-flash-0731 |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The core behavior change — offerDockerRun returning "starting" when the health check times out — had no integration test through runInit. Add two tests: local mode verifies the connect message shows "starting in the background", remote mode verifies the public URL probe is skipped. Both mutation-verified. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
startcommand kills the still-syncing container and restarts from scratch — an instruction-following user loops indefinitely on a long first sync.offerDockerRunreturnedboolean, collapsing "never started" and "started but still coming up" into the samefalse.StartStatus("running" | "starting" | "not-started") and threads it through both connect-message builders. The "starting" variant shows "starting in the background — check progress: docker logs vault-cortex" instead of the start command.Test plan
Generated with Claude Code