-
Notifications
You must be signed in to change notification settings - Fork 1
docs: cross-link vault-onboarding companion skill; add pkm keywords #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
aliasunder
wants to merge
12
commits into
main
Choose a base branch
from
docs/vault-onboarding-crosslink
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
fa38a30
docs: cross-link vault-onboarding companion skill; add pkm keywords
aliasunder fc12b31
chore: add pkm keywords to CLI package
aliasunder 3b652b7
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder 9047680
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder d2fed3b
Merge origin/main into docs/vault-onboarding-crosslink (resolve keywo…
aliasunder d4ba167
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder cba6f63
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder 56353bf
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder cfc8dc2
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder ccdec8d
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder ddb4dd2
Merge remote-tracking branch 'origin/main' into docs/vault-onboarding…
aliasunder 78cbc2b
Merge branch 'main' into docs/vault-onboarding-crosslink
aliasunder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align PR description with the actual keyword change
Low severity · subtle bugs · high confidence
The PR description claims package.json keywords were changed as
attachments → pkm + personal-knowledge-management (kept pdf), but the diff only addssecond-brainto cli/package.json;attachmentsremains in the list andpkm/personal-knowledge-managementwere already present before this PR.Failure scenario: A maintainer relying on the PR description to review the keyword change believes
attachmentswas removed from the published npm package's keywords, but it is still shipped, so the LobeHub listing (generated from these keywords post-merge) still advertisesattachmentswhile the description claimed otherwise.Suggested fix