fix(review): content dedup follow-ups — coalesceAnchors, titleSimilarity, logging - #86
Merged
Merged
Conversation
Three fixes from unresolved bot threads on the merged PR: 1. coalesceAnchors uses positional-only dedup for tracked-findings count — content similarity must not collapse genuinely distinct prior findings that share title vocabulary 2. titleSimilarity deduplicates internally via Sets so the result stays in [0, 1] for arbitrary input 3. Content-tier suppressions logged at warn level with file, line, category, and title for observability and threshold tuning 581 tests, lint clean, build clean. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![umm-actually[bot]](https://avatars.githubusercontent.com/in/4233716?s=60&v=4){kind=small}
Contributor
|
umm-actually re-reviewed at No new findings (5 tracked finding(s) across all runs). umm-actually · deepseek/deepseek-v4-flash-0731 |
…ontent-tier integration test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes from unresolved bot review threads on the merged PR #85 (content-based cross-run dedup):
coalesceAnchorsuses positional-only dedup — the content tier was over-collapsing the tracked-findings count, treating genuinely distinct prior findings as one when their titles shared vocabulary. The count now only collapses anchors within the 5-line positional window (same file + same category), matching the pre-PR feat(review): content-based cross-run dedup for shifted/reworded findings #85 behavior for counting while keeping the content tier for new-finding suppression.titleSimilaritydeduplicates internally via Sets — the exported function now guarantees [0, 1] for arbitrary input, not just pre-deduplicatednormalizeTitleoutput.droppedByPositionalanddroppedByContentcounts for threshold tuning from run logs.Test plan
coalesceAnchorstest updated: content-similar anchors across different categories are now kept as distinct