Skip to content

feat(ship-check): add --model flag, default agents to inherit session model - #14

Merged
aliasunder merged 1 commit into
mainfrom
worktree-ship-check-model-option
Sep 7, 2026
Merged

feat(ship-check): add --model flag, default agents to inherit session model#14
aliasunder merged 1 commit into
mainfrom
worktree-ship-check-model-option

Conversation

@aliasunder

Copy link
Copy Markdown
Owner

Summary

  • Change all 4 ship-check agent definitions from model: opus to model: inherit so phase agents default to the session's model — enables cost-effective runs on OpenRouter/ORI with non-Anthropic models (e.g. DeepSeek v4 Flash)
  • Add --model <name> flag to the ship-check orchestrator skill (sonnet/opus/haiku/fable) to override when a specific Anthropic tier is needed
  • Update all 4 dispatch templates to pass the model parameter when --model is specified

Behavior

Scenario Phase agent model
/ship-check (no flag) Session's model (inherited)
/ship-check --model opus Opus (overridden)
/ship-check --model sonnet Sonnet (overridden)
/ship-check --inline (any --model) Session's model (--model ignored)

Test plan

  • Run /ship-check without --model — agents should inherit session model
  • Run /ship-check --model opus — agents should dispatch on opus
  • Verify --model is ignored with --inline

🤖 Generated with Claude Code

… model

Agent definitions change from `model: opus` to `model: inherit` so phase
agents match the session's model by default — enabling cost-effective runs
on OpenRouter/ORI with non-Anthropic models like DeepSeek. The new --model
flag (sonnet/opus/haiku/fable) overrides when a specific Anthropic tier is
needed (e.g. `--model opus` for thoroughness on a cheaper session model).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@aliasunder
aliasunder merged commit c6a9fc4 into main Sep 7, 2026
7 checks passed
@aliasunder
aliasunder deleted the worktree-ship-check-model-option branch September 7, 2026 19:42
Comment thread plugins/ship-check/skills/ship-check/SKILL.md
Comment thread plugins/ship-check/skills/ship-check/SKILL.md
@umm-actually

umm-actually Bot commented Sep 7, 2026

Copy link
Copy Markdown

Update the ship-check skill path in the plugin README
Low severity · correctness · medium confidence

plugins/ship-check/README.md:33 — beyond the diff's line ranges, in code the changes touch or depend on.

Pre-existing: the README states the agents are dispatched by the ship-check skill '(in ~/.claude/skills/ship-check/)', but the skill is bundled in the plugin at plugins/ship-check/skills/ship-check/ per AGENTS.md. The parenthetical is a stale path reference.

Failure scenario: A reader who installs the plugin from the marketplace looks for the skill at ~/.claude/skills/ship-check/ and does not find it there, or manually installs a copy that drifts from the plugin version.

Suggested fix
Reference the plugin-bundled path, or state both the bundled and manual-install locations.

umm-actually · deepseek/deepseek-v4-flash-0731

@umm-actually

umm-actually Bot commented Sep 7, 2026

Copy link
Copy Markdown

umm-actually reviewed at a031b5c

3 new finding(s) posted (3 tracked finding(s) across all runs).

Context notes
  • Priority docs already in context: plugins/ship-check/agents/bug-checker.md, plugins/ship-check/agents/code-quality-reviewer.md, plugins/ship-check/agents/pr-reviewer.md, plugins/ship-check/agents/test-auditor.md, plugins/ship-check/skills/ship-check/SKILL.md

umm-actually · deepseek/deepseek-v4-flash-0731

aliasunder added a commit that referenced this pull request Sep 7, 2026
… reviews

The README pointed at ~/.claude/skills/ship-check/ for the orchestrator
skill; it is bundled in the plugin. The pre-merge delta review step now
states explicitly that the --model override applies to its dispatches.

Addresses the two remaining umm-actually findings on #14.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@aliasunder

Copy link
Copy Markdown
Owner Author

Re: Update the ship-check skill path in the plugin README — valid, this was not addressed before merge. Fixed on main in 9483e6b: plugins/ship-check/README.md now says the skill is bundled in the plugin at skills/ship-check/ instead of pointing at ~/.claude/skills/ship-check/. Posted via Claude Code (claude-fable-5-1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant