fix(pr-monitor): decide comment new-ness by id and timestamp, not body text - #13
Merged
Conversation
…y text After a re-review event, the comment-reading step now requires listing both endpoints (inline review comments and issue comments) with id and created_at, and treating a comment as new only if it postdates the run that produced it. Identical text with a familiar marker means the same comment was re-read, not re-posted. Also bolds the pipeline attribution footer at the top of Step 3 — the reply templates carried it, but the transition from direct posting into a pipeline cycle was easy to miss. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![umm-actually[bot]](https://avatars.githubusercontent.com/in/4233716?s=60&v=4){kind=small}
|
umm-actually re-reviewed at No new findings (3 tracked finding(s) across all runs). Context notes
umm-actually · deepseek/deepseek-v4-flash-0731 |
The new-ness rule requires listing inline review comments with id and created_at, but 2d's fetch block never queried /pulls/N/comments — an agent following the skill literally still could not see them. Adds the endpoint to the fetch block and the proof-of-work listing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
… per-surface timestamps The empty-listing self-report now names all three fetched surfaces, and Step 4.3 scopes the timestamp comparison by surface — review bodies expose submitted_at, not created_at. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the comment-reading gap that caused a real monitoring misfire on vault-cortex PR #538: after a re-review event, an issue-comments-only query re-read the round-1 comment as a "duplicate" on two consecutive passes while the bot's actual new findings — posted as inline review comments — went unseen.
idandcreated_at, and treat a comment as new only if it postdates the run that produced it. A "duplicate posting" verdict requires two distinct comment ids.created_atas the comparison keys.Tests
Prose-only skill change — no executable surface. Verified the three edited sections render correctly and the surrounding step numbering and flow are unchanged.
🤖 Generated with Claude Code