Skip to content

fix: make GitForge strict CI green - #60

Merged
aliasfoxkde merged 35 commits into
feat/comprehensive-ci-cd-pipelinefrom
delegated/ci-failures-20260827
Aug 27, 2026
Merged

aliasfoxkde merged 35 commits into
feat/comprehensive-ci-cd-pipelinefrom
delegated/ci-failures-20260827

Conversation

@aliasfoxkde

Copy link
Copy Markdown
Owner

Validated on Fedora: API environment tests, delta doctest, full workspace tests with all features, cargo fmt check, and cargo clippy with -D warnings. Functional repair: e4cd50a. Workspace formatting: 5811c90. Strict lint repair: c3abebc and 4f84ed4.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f28d747b-e7a4-49ce-a2d5-5f09c83b972a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread Makefile Fixed
Comment thread docs/RUNBOOK.md Fixed
Comment thread scripts/setup-services.sh Fixed

- name: Upload base benchmark
if: -f benchmark_current.json
if: hashFiles('benchmark_current.json') != ''
@github-actions

Copy link
Copy Markdown

Benchmark Results

First benchmark run on this PR. No previous baseline available for comparison.

See artifacts for full benchmark data.

@github-actions

Copy link
Copy Markdown

Benchmark Results

First benchmark run on this PR. No previous baseline available for comparison.

See artifacts for full benchmark data.

@github-actions

Copy link
Copy Markdown

Benchmark Results

First benchmark run on this PR. No previous baseline available for comparison.

See artifacts for full benchmark data.

@github-actions

Copy link
Copy Markdown

Benchmark Results

First benchmark run on this PR. No previous baseline available for comparison.

See artifacts for full benchmark data.

@github-actions

Copy link
Copy Markdown

Benchmark Results

First benchmark run on this PR. No previous baseline available for comparison.

See artifacts for full benchmark data.

Replace Unix-only tokio::signal::unix with cfg-gated handling:
- Unix: tokio::signal::unix::signal() for SIGTERM/SIGINT via tokio::select!
- Windows: tokio::signal::ctrl_c() for console interrupt events

Fixes confirmed Windows GNU CI failure where tokio::signal::unix
is not available on Windows targets.
@github-actions

Copy link
Copy Markdown

Benchmark Results

First benchmark run on this PR. No previous baseline available for comparison.

See artifacts for full benchmark data.

Use #[cfg(unix)] / #[cfg(not(unix))] conditionals in spawn_shutdown_handler
to guard tokio::signal::unix::signal() (Unix-only) and use tokio::signal::ctrl_c()
for cross-platform Ctrl+C handling, matching the pattern already applied to
services/ci/src/main.rs.
@github-actions

Copy link
Copy Markdown

Benchmark Results

First benchmark run on this PR. No previous baseline available for comparison.

See artifacts for full benchmark data.

@aliasfoxkde
aliasfoxkde merged commit 481eb50 into feat/comprehensive-ci-cd-pipeline Aug 27, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants