Repository navigation
fix(runner): retry sandbox teardown failures - #370
Open
aliasfoxkde wants to merge 1 commit into
Open
aliasfoxkde wants to merge 1 commit into
aliasfoxkde wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
🤖 AI Code Review ResultsAI review skipped: provider 'anthropic' is not configured; deterministic gates remain authoritative. ✅ No critical issues found. AI Code Review powered by GitForge |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo test --offline -p gitforge-runner --lib— 127 passed, 2 ignored.test_real_docker_job_timeout_reaps_sandbox— passed.test_real_docker_job_cancel_reaps_sandbox— passed.cargo test -p gitforge-sandbox --lib— 94 passed, 3 ignored.gitforge-runnerandgitforge-sandbox— passed.cargo fmt --all -- --checkandgit diff --check— passed.Refs #277. This PR addresses in-process teardown retries. Persistent cleanup recovery after abrupt runner-process death and pressure-aware job admission remain open follow-up work in #277.