Repository navigation
refactor: linearize main history for required-linear-history ruleset - #368
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
2 of 3 tasks
aliasfoxkde
force-pushed
the
reconcile/linearize
branch
from
November 3, 2026 21:54
d155ba2 to
ac99fe2
Compare
🤖 AI Code Review ResultsAI review skipped: provider 'anthropic' is not configured; deterministic gates remain authoritative. ✅ No critical issues found. AI Code Review powered by GitForge |
Route-by-route inventory of the API surface with auth class and per-handler authorization check for every registered route. Anchors the registration and webhook findings fixed in the preceding commit.
…dicts - /metrics and /dashboard require auth unless GITFORGE_PUBLIC_TELEMETRY=1 (F5); /health stays public; decision core + middleware tests - pipeline_runs.ref_name column; webhook/ci populate it; supersede and integration/scheduler tests updated - release gate: unconditional-job check accepts satisfied rows (succeeded or skipped); quality-chain names stay fails-closed; gate tests extended - ledger verdicts for F1-F5 and the 2026-11-02 queue incident; F4 recorded as a design decision; architecture audit appended to the execution plan; __pycache__ ignored Co-Authored-By: Claude <noreply@anthropic.com>
/metrics and /dashboard were merged into public_routes, bypassing the auth middleware entirely, so the GITFORGE_PUBLIC_TELEMETRY gate was dead code at the route boundary. Wire both surfaces into the protected router by default and into public_routes only on explicit opt-in. Integration tests now pin the boundary: anonymous 401 by default, 200 with opt-in.
Make telemetry_is_public crate-visible and clone the metrics router so it can be merged into either the public or protected router without a double move.
The default-posture telemetry routes were merged into the /api-nested protected router, which relocated them to /api/metrics and /api/dashboard and left the canonical paths a 404. Mount them at top level behind their own auth-middleware layer instead. Serialize the three env-mutating telemetry tests with a shared mutex: the decision is read from the process env at router-build time, so parallel test threads race and randomly invert the asserted posture.
aliasfoxkde
force-pushed
the
reconcile/linearize
branch
from
November 3, 2026 22:56
ac99fe2 to
9a403a1
Compare
🤖 AI Code Review ResultsAI review skipped: provider 'anthropic' is not configured; deterministic gates remain authoritative. ✅ No critical issues found. AI Code Review powered by GitForge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan