feat(identify): send user data to identify after oauth flow#228
Open
LorrisSaintGenez wants to merge 2 commits into
Open
feat(identify): send user data to identify after oauth flow#228LorrisSaintGenez wants to merge 2 commits into
LorrisSaintGenez wants to merge 2 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 30 |
| Duplication | 14 |
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Persist the authenticated user's identity alongside the OAuth tokens so CLI telemetry can attribute events to the logged-in user.
StoredTokennow carriesuser_id/email/name, populated bySaveTokenfrom the OAuth response'suserobject (same keychain entry — identity is bound to the token, not a profile).LoadToken. Any caller reads identity straight off the stored token.root.gopopulatesCLIAnalyticsEventMetadatafrom the stored token beforeIdentify/Track. When authenticated, both carryuserId(alongsideanonymousId, so the first event aliases anonymous→user);email/namego onIdentifytraits.GetValidTokenback-fills identity from the refresh response for sessions created before this change, and preserves stored identity when a refresh response omits the user.Test
Preview
GROUT-350