Mini challenge 1#1
Open
alfredo-pacheco wants to merge 3 commits into
Open
Conversation
PacoMojica
reviewed
Feb 24, 2021
PacoMojica
left a comment
PacoMojica
left a comment
There was a problem hiding this comment.
Awesome deliverable, keep the good work 👍
Comment on lines
+6
to
+11
| return ( | ||
| <MainContainer> | ||
| <Header>This is the header</Header> | ||
| <Content>{children}</Content> | ||
| </MainContainer> | ||
| ); |
There was a problem hiding this comment.
Good, I like this, it is simple but expressive
Comment on lines
+22
to
+28
| <VideoCard key={item.id.videoId}> | ||
| <VideoPreview src={item.snippet.thumbnails.medium.url} /> | ||
| <VideoContent> | ||
| <VideoTitle>{item.snippet.title}</VideoTitle> | ||
| <VideoDescription>{item.snippet.description}</VideoDescription> | ||
| </VideoContent> | ||
| </VideoCard> |
There was a problem hiding this comment.
The way you keep the VideoCard components separate helps with readability, you can go one step further and move all the things related to the VideoCard to a separate file, this way you can test the component easily
Comment on lines
+39
to
+47
| export { | ||
| Title, | ||
| VideosContainer, | ||
| VideoCard, | ||
| VideoPreview, | ||
| VideoContent, | ||
| VideoTitle, | ||
| VideoDescription, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mini-challenge-1 for React Bootcamp.